New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace react-content-loader with css implementation. #484

Merged

lgalis merged 1 commit into RedHatInsights:master from Hyperkid123:patch-content-loader-safari

Mar 26, 2020

Contributor

Hyperkid123 commented Mar 26, 2020

a detailed description of the issue: danilowoz/react-content-loader#93

jira: https://projects.engineering.redhat.com/browse/SSP-1385

There are no visual changes

Issues

safari browser is displaying black stripes in content loaders
fix for safari broke chrome on Linux so I removed the library and implemented it using CSS
CSS implementation should have much better browser support and is actually customizable


          Replace react-content-loader with css implementation.

508bcea

Hyperkid123 added the bug label

Hyperkid123 requested a review from lgalis

March 26, 2020 12:49

lgalis approved these changes

View reviewed changes

lgalis merged commit d57a9c7 into RedHatInsights:master

Hyperkid123 deleted the patch-content-loader-safari branch

March 27, 2020 07:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment